Well welcome aboard, you did a good job over all. Parts creation is unfortunately poorly documented so mostly you learn by trying and asking questions here. The part file format document available here gives good information on layers (although there are lots of subtle parts that are not in there too):
I have a python script (python 3 only so far) available here:
which will tell you a number of things that it finds wrong (which it will flag as errors) and unusual and thus possibly wrong (flagged as warnings), but it assumes a fairly good knowledge of the format of the underlying files and thus isn’t as clear as it might be. As I said the main problem with your part was the lack of the copper0 layer in pcb. That makes the part only appear on one side of the board (which is correct for SMD parts but not through hole like this one). The rest of the stuff isn’t as serious although it is desirable to have it correct. Feel free to post more parts and one or another of us will point out problems we see. The more people making new parts the better.
Peter